Trouble with custom post type pagination WordPress

John Cotton comments:

Thanks IV, but that doesn't make any difference. The problem seems to be that the code doesn't know it's looking at a custom post type - nothing is being returned by the query hence the 404.

Ivaylo Draganov comments:

Could you please post the code that you are using (both for registering the post type and in the template)? And are you using a custom taxonomy or the built-in ones?

John Cotton comments:

Built in categories - but that could easily be changed if it makes a difference.

Here's the registration code:
$labels = array(
'name' => 'Directory',
'singular_name' => 'Directory Entry',
'add_new' => 'Add New',
'add_new_item' => 'Add New Entry',
'edit_item' =>'Edit Entry',
'new_item' => 'New Entry',
'view_item' =>'View Entry',
'search_items' => 'Search Entries',
'not_found' => 'No entries found',
'not_found_in_trash' => 'No entries found in Trash',
'parent_item_colon' => ''
);

$args = array(
'labels' => $labels,
'public' => true,
'capability_type' => 'post',
'hierarchical' => false,
'rewrite' => array( 'slug' => 'good-directory', 'with-front' => False ),
'query_var' => true,
'supports' => array('title','editor','author','thumbnail','custom-fields','revisions','excerpt','comments'),
'taxonomies' => array( 'category', 'post_tag' ),
'menu_position' => 5,
);
register_post_type('directory', $args);

John Cotton comments:

Template code is

<?php
add_filter('posts_orderby', 'and_by_title' );
function and_by_title( $orderby )
{
return $orderby . ", post_title ASC";
}

global $wpdb;

$paged = (get_query_var('paged')) ? get_query_var('paged') : 1;

query_posts(array(
'post_type' => 'directory',
'posts_per_page' => -1,
'post_status' => 'publish',
'paged' => $paged,
'meta_key' => '_gdBoldEntry',
'orderby' => 'meta_value',
'order' => 'DESC',
'cat' => get_category_descendent_ids($cat),
));

if ( have_posts() ) :
while ( have_posts() ) : the_post();
$CSSclass = get_post_meta($post->ID, '_gdBoldEntry', true) == "True" ? "awesome orange" : "notBold";
?>

<div id="post-<?php the_ID(); ?>" class="<?php echo $CSSclass ?>">

<h4><a href="<?php the_permalink() ?>" rel="bookmark" title="link to <?php the_title(); ?>"><?php the_title(); ?></a> <?php edit_post_link('<button class="editEntry">edit</button>', '', ''); ?></h4>

</div>
<?php
endwhile;
endif;

if(function_exists('wp_page_numbers')) : wp_page_numbers(); endif;

remove_filter('posts_orderby', 'and_by_title' );
wp_reset_query();
?>


Ivaylo Draganov comments:

Please clarify in which template file you place this code.

And... hm... why do you have <em>'posts_per_page' => -1</em> when you want pagination? Setting it to <em>-1</em> causes all posts to be displayed regardless of other parameters. Try commenting out 'posts_per_page' or setting it to a different value.

John Cotton comments:

'post_per_page' = -1: Sorry, that's my mistake. I have it set to -1 just to see the output and check row count -normally it's 40 so that pagination appears. I forgot to set it back before cutting and pasting.

Code sits in category.php via an include_once. That's working obviously since I correctly see the first page (for a large number of different categories).

John

Ivaylo Draganov comments:

I think you need to include this kind of code:


// include custom post types in the loop
// http://bajada.net/2010/08/31/custom-post-types-in-the-loop-using-request-instead-of-pre_get_posts
add_filter( 'request' , 'ucc_request_filter' );
function ucc_request_filter( $query ) {
/* Preview does not like having post_type set; feed is my personal preference. */
if ( empty( $query['preview'] ) && empty( $query['feed'] ) ) {
$my_post_type = $query['post_type'];
if ( empty( $my_post_type ) ) {
$query['post_type'] = 'any';
}
}

return $query;
}


It adds you custom post type to the WP query. And it will appear on your home page and category pages without having to add 'post_type' to <em>query_posts</em>. Give it a try.

Maor Barazany comments:

By the way, that is a known issue on WP3.0 and 3.0.1, they just didn't create a them hierarchy file for custom posts type, and thus all of these issues.
I think I saw in WP Dev blog that they intend to extend the template hierarchy in WP3.1 to include also file for custom-post-type's archive page, and then it will be simple as having pagination to any other posts archives.
Till 3.1, the Simple Custom Post Type Archives I suggested just do the job of having this template file hierarchy enabled and doing the correct rewrites that should be done for this to work.

John Cotton comments:

Thanks Maor, but this works when I put ?post_type=CUSTOM_POST_TYPE on the url - which is where I was with the other solutions.

You can see it for yourself here:

http://www.golfbusinessnews.com/category/good-directory/pro-shop/

And then try

http://www.golfbusinessnews.com/category/good-directory/pro-shop/?post_type=directory

If you look at the source just after <!-- end header --> , you'll see which file is generating the content.

There's a whole load of debug output at the bottom of the source which constantly points to WP not knowing that the post type is a custom one as the problem (the SQL has post_type="post" in it).

That only changes when I change the post_type in the URL.

John